Merge pull request #924 from DeluxeAlonso/feature/code-cleanup

Feature/code cleanup
DeluxeAlonso · Jul 5, 2024 · ee0d518 · ee0d518
2 parents 741bc58 + 597a53b
commit ee0d518
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 4 deletions.
diff --git a/UpcomingMovies/Helpers/Utils/Localization/LocalizedStrings.swift b/UpcomingMovies/Helpers/Utils/Localization/LocalizedStrings.swift
@@ -84,4 +84,8 @@ enum LocalizedStrings: String, Localizable {
     case customListDetailSectionRuntimeTitle
     case customListDetailSectionRevenueTitle
 
+    case errorPlaceHolderViewTitleText
+    case errorPlaceHolderViewDetailText
+    case errorPlaceHolderViewRetryButtonTitle
+
 }
diff --git a/UpcomingMovies/ViewComponents/PlaceholderViews/Error/ErrorPlaceholderView.swift b/UpcomingMovies/ViewComponents/PlaceholderViews/Error/ErrorPlaceholderView.swift
@@ -89,11 +89,10 @@ final class ErrorPlaceholderView: UIView, NibLoadable, RetryPlaceHolderable {
 
 extension ErrorPlaceholderView {
 
-    // TODO: - Localize this
     struct Constants {
-        static let errorTitle = "¡Ups!"
-        static let errorDetail = "Something went wrong."
-        static let retryButtonTitle = "Retry"
+        static let errorTitle = LocalizedStrings.errorPlaceHolderViewTitleText()
+        static let errorDetail = LocalizedStrings.errorPlaceHolderViewDetailText()
+        static let retryButtonTitle = LocalizedStrings.errorPlaceHolderViewRetryButtonTitle()
     }
 
 }
diff --git a/UpcomingMovies/en.lproj/Localizable.strings b/UpcomingMovies/en.lproj/Localizable.strings
@@ -87,3 +87,7 @@
 "customListDetailSectionRatingTitle" = "Rating";
 "customListDetailSectionRuntimeTitle" = "Runtime";
 "customListDetailSectionRevenueTitle" = "Revenue";
+
+"errorPlaceHolderViewTitleText" = "¡Ups!";
+"errorPlaceHolderViewDetailText" = "Something went wrong.";
+"errorPlaceHolderViewRetryButtonTitle" = "Retry";
diff --git a/UpcomingMovies/es-419.lproj/Localizable.strings b/UpcomingMovies/es-419.lproj/Localizable.strings
@@ -87,3 +87,7 @@
 "customListDetailSectionRatingTitle" = "Rating";
 "customListDetailSectionRuntimeTitle" = "Duración";
 "customListDetailSectionRevenueTitle" = "Ganancias";
+
+"errorPlaceHolderViewTitleText" = "¡Ups!";
+"errorPlaceHolderViewDetailText" = "Ocurrió un error.";
+"errorPlaceHolderViewRetryButtonTitle" = "Reintentar";