Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/code cleanup #926

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Feature/code cleanup #926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee7ad3a
Fixes minor syntax issue in MovieDetailCoordinator
DeluxeAlonso Jul 8, 2024
657866f
Merge branch 'development' of https://github.com/DeluxeAlonso/upcomin…
DeluxeAlonso Jul 8, 2024
11df8e1
Updates SearchMoviesResultInteractor
DeluxeAlonso Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion UpcomingMovies/Scenes/Movies/MovieDetail/MovieDetailCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ final class MovieDetailCoordinator: BaseCoordinator, MovieDetailCoordinatorProto

// MARK: - Initializers

init(navigationController: UINavigationController, movieInfo: MovieDetailInfo) {
init(navigationController: UINavigationController,
movieInfo: MovieDetailInfo) {
self.movieInfo = movieInfo
super.init(navigationController: navigationController)
}
Expand Down
6 changes: 5 additions & 1 deletion UpcomingMovies/Scenes/Movies/SearchMovies/SearchResult/SearchMoviesResultInteractor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@

var didUpdateMovieSearches: (() -> Void)?

private var currentUser: User? {
authHandler.currentUser()

Check warning on line 21 in UpcomingMovies/Scenes/Movies/SearchMovies/SearchResult/SearchMoviesResultInteractor.swift

View check run for this annotation

Codecov / codecov/patch

UpcomingMovies/Scenes/Movies/SearchMovies/SearchResult/SearchMoviesResultInteractor.swift#L20-L21 

Added lines #L20 - L21 were not covered by tests
}

init(useCaseProvider: UseCaseProviderProtocol, authHandler: AuthenticationHandlerProtocol) {
self.movieUseCase = useCaseProvider.movieUseCase()
self.movieSearchUseCase = useCaseProvider.movieSearchUseCase()
Expand All @@ -28,7 +32,7 @@
}

func searchMovies(searchText: String, page: Int?, completion: @escaping (Result<[MovieProtocol], Error>) -> Void) {
let includeAdult = authHandler.currentUser()?.includeAdult ?? false
let includeAdult = currentUser?.includeAdult ?? false

Check warning on line 35 in UpcomingMovies/Scenes/Movies/SearchMovies/SearchResult/SearchMoviesResultInteractor.swift

View check run for this annotation

Codecov / codecov/patch

UpcomingMovies/Scenes/Movies/SearchMovies/SearchResult/SearchMoviesResultInteractor.swift#L35 

Added line #L35 was not covered by tests
movieUseCase.searchMovies(searchText: searchText,
includeAdult: includeAdult,
page: page, completion: { result in
Expand Down
Loading