Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for issue #48 #156

Merged
merged 5 commits into from
Jan 31, 2023
Merged

Added unit tests for issue #48 #156

merged 5 commits into from
Jan 31, 2023

Conversation

MrDave1999
Copy link
Member

@MrDave1999 MrDave1999 commented Jan 31, 2023

Related to #48, #155.

…lass

This was added in a separate class of 'WaterfallStepContextExtensions' to facilitate unit testing.

The advantage is that our new 'UserProfileFactory' class does not depend directly on 'WaterfallStepContext' (therefore it is no longer necessary to create an instance of this class in our unit tests).
@MrDave1999 MrDave1999 marked this pull request as ready for review January 31, 2023 23:49
@MrDave1999 MrDave1999 merged commit 9dca810 into dev Jan 31, 2023
@MrDave1999 MrDave1999 deleted the tests-issue-48 branch January 31, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant