Add Docker Compose files for simplified local testing #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nscuro
force-pushed
the
test-compose-files
branch
from
36d1dc4
to
755ba5f
Compare
These make it easier to test database migrations and compatibility with the different RDBMSes in general. Also simplifies testing the impact of performance critical functions with Prometheus metrics. But to be honest the main motivation to add these files is that I always forget how to set up MSSQL locally. Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
nscuro
force-pushed
the
test-compose-files
branch
from
755ba5f
to
be01a3d
Compare
Signed-off-by: nscuro <[email protected]>
To make it clear that these Compose files are only meant for dev and testing work. Avoiding confusion with the existing `src/main/docker/docker-compose.yml`, which is also used as quickstart. Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds multiple Docker Compose files that simplify local testing in various deployment constellations.
These make it easier to test database migrations and compatibility with the different RDBMSes in general. Also simplifies testing the impact of performance critical functions with Prometheus metrics.
But to be honest the main motivation to add these files is that I always forget how to set up MSSQL locally.
Addressed Issue
N/A
Additional Details
Not super-sure where to best put these files.
I don't want them to cause confusion as we already have
src/main/docker/docker-compose.yml, which is linked on the website, too. As the files in this PR are mainly for local testing, they probably should reside in some sort ofhackordevdirectory?Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly