Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing (postgres) operators. #211

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

antoineB
Copy link
Contributor

The operators of posix regexp, bit string, network addresses, point, full text search, range and some missing json operators have been added.

Following postgres operators precedence
https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-PRECEDENCE. They have the 'binary_other' precedence rule, and to reduce the size of the parser they all produce the either token 'op_other' or 'op_unary_other'.

The operators of posix regexp, bit string, network addresses, point, full text
search, range and some missing json operators have been added.

Following postgres operators precedence
https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-PRECEDENCE.
They have the 'binary_other' precedence rule, and to reduce the size of the
parser they all produce the either token 'op_other' or 'op_unary_other'.
Copy link
Collaborator

@matthias-Q matthias-Q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it is time to update downstream projects like nvim-treesitter, helix etc. Their highlights.scm queries should know the newly added keywords and tokens.

@matthias-Q matthias-Q merged commit eb22547 into DerekStride:main Nov 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants