Fix/update bindings #260
Merged
Fix/update bindings #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpse
force-pushed
the
fix/update-bindings
branch
from
895ecb1
to
690682b
Compare
grpse
force-pushed
the
fix/update-bindings
branch
from
3e2f034
to
6495c58
Compare
matthias-Q
reviewed
Jun 24, 2024
DerekStride
reviewed
Jun 28, 2024
|
thanks for working on this.... once this lands, we can integrate sql parser to ast-grep to enable automated code transformation of sql for a variety of use cases. so looking forward to it. |
DerekStride
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
trying to use inside of a node project, the binding when calling
setLanguagefrom node tree-sitter, was throwing an errorType error: Invalid language object. This was due to the use ofnanin the old binding from tree-sitter, but now it uses node-addon-api, so I've updated it. Also, for wasm build, the scanner.c uses strcpy, but it is not available symbol after compilation with new version of tree-sitter.