tree-sitter 0.23 upgrade #279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhitworth
force-pushed
the
tree-sitter-0.23
branch
from
ea52e75
to
47a897f
Compare
|
LGTM. I was wondering if you should bump right up to tree-sitter 0.24 instead of 0.23. I also ask myself why it fails on Windows. If I have time, I will investigate. |
I've prepared a separate branch to upgrade to 0.24. I'll create a PR now. (edit: #283) Given the churn in bindings in 0.23 and 0.24, separating out the two version upgrades might help with any issue attribution later on. |
mwhitworth
force-pushed
the
tree-sitter-0.23
branch
from
47a897f
to
12c37bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for this upgrade is to move the Rust binding to depending on
tree-sitter-language, which is a much more stable library that simplifies furthertree-sitterupgrade for Rust projects.For now, I've restored the
package.jsonscripts that were updated by the tool. These can be made upgrade-proof in a separate PR, I think.