Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counter and channel implementations #60

Closed
wants to merge 21 commits into from
Closed

Counter and channel implementations #60

wants to merge 21 commits into from

Conversation

Detegr
Copy link
Owner

@Detegr Detegr commented Nov 12, 2019 •
edited
Loading

These still need documentation and reducing the size of unsafe blocks. However, the functionality is there and I haven't found any bugs. I've tested the implementation on Linux, Windows, and FreeBSD.

@Detegr Detegr force-pushed the counter+channel branch 2 times, most recently from 2c669a4 to ac40e34 Compare June 10, 2021 19:52
@Detegr
Deprecate feature termination
7a6e2d5 
Remove SignalType::Termination as it is a bit problematic because a
simple one-to-one signal map for it is usually not what the user wants.
Also as it was behind a feature flag it caused workspace infection, see
issue #74.

Fixes #74
@Icelk
Copy link

Icelk commented May 26, 2022

Hi! Great project. Are there any updates on this?

@Detegr
Copy link
Owner Author

Detegr commented May 26, 2022

If I recall correctly this branch worked okay last time I checked but I lack the courage to publish this as a new version because this is a widely used crate by now and I'm afraid I'm doing something stupid unless I get some code reviews for this. The code reviews may never happen, and it might be that I'll never release this branch. We will see.

@Icelk
Copy link

Icelk commented May 26, 2022

Don't hesitate to ask if there's anything I can do.

@Detegr Detegr mentioned this pull request Jul 29, 2022
Closed
@Detegr
Copy link
Owner Author

Detegr commented Jul 29, 2022

Code reviews for this are highly appreciated to get this moving forward.

@ghost
Copy link

ghost commented Aug 22, 2022 •
edited by ghost
Loading

i just tested macOS. all the examples work fine, and all tests pass

@Detegr
Copy link
Owner Author

Detegr commented May 20, 2023 •
edited
Loading

Close to four years with no proper code reviews, I'm closing this PR. I don't expect this to be ever merged in. There are good alternatives available if you need some fancier signal handling mechanisms.

@Detegr Detegr closed this May 20, 2023
@Detegr Detegr mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Detegr @Icelk