New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't raise an exception on a non-zero output #16

Merged

grahamc merged 1 commit into main from nonzero-err

May 9, 2024

Member

grahamc commented May 9, 2024

No description provided.


          Don't raise an exception on a non-zero output

a4cfe67

grahamc commented

View reviewed changes

src/index.ts

@@ @@ -86,6 +86,7 @@ class FlakeCheckerAction { @@
                       ...executionEnv,
                       ...process.env, // To get $PATH, etc
                     },
+                    ignoreReturnCode: true,

Member Author

grahamc May 9, 2024

This signals to the exec library to not raise an exception on a non-zero error. Since we handle that case immediately below, we don't need it.

flexiondotorg approved these changes

View reviewed changes

grahamc merged commit 8b83576 into main

5 checks passed

grahamc deleted the nonzero-err branch

May 9, 2024 23:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet