DS-970: Add Magic Nix Cache and other workflow changes #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An assortment of GitHub Workflow changes, potentially including: - Enable DeterminateSystems/magic-nix-cache-action@main - Reference all DeterminateSystems actions via @main - Make update.yaml consistent across repos - Remove unnecessary github-token: from nix-installer-action - Update actions/checkout@v2 to actions/checkout@v3
Hoverbear
reviewed
Jul 14, 2023
.github/workflows/ci.yml
Outdated
| uses: DeterminateSystems/nix-installer-action@v4 | ||
| uses: DeterminateSystems/nix-installer-action@main | ||
| - name: Enable magic Nix cache | ||
| uses: DeterminateSystems/magic-nix-cache-action@main |
There was a problem hiding this comment.
I am not entirely sure how wise it is to make an action depend on itself like this...
|
@Hoverbear Thanks for the feedback 👍 I've removed the magic Nix cache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An assortment of GitHub Workflow changes, potentially including: