-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action: post-run-job: try clean daemon container, warn on failure #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemickens
force-pushed
the
colemickens/ghes-docker-cleanup
branch
from
December 11, 2023 16:06
afef26a
to
78e3e43
Compare
Added another commit to use |
This lgtm but I can't give it a actual code review right now, just an idea review. |
grahamc
approved these changes
Dec 19, 2023
🎊 |
mmlb
referenced
this pull request
in packethost/packet-networking
Mar 18, 2024
… v10 (#82) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [DeterminateSystems/nix-installer-action](https://togithub.com/DeterminateSystems/nix-installer-action) | action | major | `v9` -> `v10` | --- ### Release Notes <details> <summary>DeterminateSystems/nix-installer-action (DeterminateSystems/nix-installer-action)</summary> ### [`v10`](https://togithub.com/DeterminateSystems/nix-installer-action/releases/tag/v10) [Compare Source](https://togithub.com/DeterminateSystems/nix-installer-action/compare/v9...v10) ##### What's Changed - action: post-run-job: try clean daemon container, warn on failure by [@​colemickens](https://togithub.com/colemickens) in [https://github.com/DeterminateSystems/nix-installer-action/pull/61](https://togithub.com/DeterminateSystems/nix-installer-action/pull/61) - No longer require sudo by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/64](https://togithub.com/DeterminateSystems/nix-installer-action/pull/64) - Handle docker not existing. by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/66](https://togithub.com/DeterminateSystems/nix-installer-action/pull/66) - Don't use docker shim if only using a mounted docker.sock instead of docker-in-docker by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/67](https://togithub.com/DeterminateSystems/nix-installer-action/pull/67) - DETERMINATE_NIX_KVM fixup, support Magic Nix Cache + FlakeHub Cache on Namespace runners by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/72](https://togithub.com/DeterminateSystems/nix-installer-action/pull/72) **Full Changelog**: DeterminateSystems/nix-installer-action@v9...v10 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/packethost/packet-networking). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzguMSIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
dc-tec
referenced
this pull request
in dc-tec/nixvim
Aug 7, 2024
… v13 (#18) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [DeterminateSystems/nix-installer-action](https://togithub.com/DeterminateSystems/nix-installer-action) | action | major | `v1` -> `v13` | --- ### Release Notes <details> <summary>DeterminateSystems/nix-installer-action (DeterminateSystems/nix-installer-action)</summary> ### [`v13`](https://togithub.com/DeterminateSystems/nix-installer-action/releases/tag/v13) [Compare Source](https://togithub.com/DeterminateSystems/nix-installer-action/compare/v12...v13) ##### What's Changed This update primarily improves the docker shim mechanism. - science: probes to debug fly on GHA by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/99](https://togithub.com/DeterminateSystems/nix-installer-action/pull/99) - bump by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/100](https://togithub.com/DeterminateSystems/nix-installer-action/pull/100) - Update detsys-ts by [@​lucperkins](https://togithub.com/lucperkins) in [https://github.com/DeterminateSystems/nix-installer-action/pull/102](https://togithub.com/DeterminateSystems/nix-installer-action/pull/102) - Update detsys-ts: Merge pull request [#​51](https://togithub.com/DeterminateSystems/nix-installer-action/issues/51) from DeterminateSystems/add-missing-actions-to-update-matrix Add missing Actions to update matrix by [@​detsys-pr-bot](https://togithub.com/detsys-pr-bot) in [https://github.com/DeterminateSystems/nix-installer-action/pull/103](https://togithub.com/DeterminateSystems/nix-installer-action/pull/103) - Update `detsys-ts`: Merge pull request [#​103](https://togithub.com/DeterminateSystems/nix-installer-action/issues/103) from detsys-pr-bot/detsys-ts-update-515d00bc192ae4460e2122572ebc24020c58ea95 by [@​detsys-pr-bot](https://togithub.com/detsys-pr-bot) in [https://github.com/DeterminateSystems/nix-installer-action/pull/105](https://togithub.com/DeterminateSystems/nix-installer-action/pull/105) - Update `detsys-ts`: by [@​detsys-pr-bot](https://togithub.com/detsys-pr-bot) in [https://github.com/DeterminateSystems/nix-installer-action/pull/104](https://togithub.com/DeterminateSystems/nix-installer-action/pull/104) - README: correct the source-url parameter docs by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/108](https://togithub.com/DeterminateSystems/nix-installer-action/pull/108) - Share /lib64 into the container by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/109](https://togithub.com/DeterminateSystems/nix-installer-action/pull/109) ##### New Contributors - [@​detsys-pr-bot](https://togithub.com/detsys-pr-bot) made their first contribution in [https://github.com/DeterminateSystems/nix-installer-action/pull/103](https://togithub.com/DeterminateSystems/nix-installer-action/pull/103) **Full Changelog**: DeterminateSystems/nix-installer-action@v12...v13 ### [`v12`](https://togithub.com/DeterminateSystems/nix-installer-action/releases/tag/v12) [Compare Source](https://togithub.com/DeterminateSystems/nix-installer-action/compare/v11...v12) #### What's Changed - Fix ESM build by [@​lucperkins](https://togithub.com/lucperkins) in [https://github.com/DeterminateSystems/nix-installer-action/pull/83](https://togithub.com/DeterminateSystems/nix-installer-action/pull/83) - Revert "Fix ESM build" by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/86](https://togithub.com/DeterminateSystems/nix-installer-action/pull/86) - Add CI run for aarch64-darwin by [@​lucperkins](https://togithub.com/lucperkins) in [https://github.com/DeterminateSystems/nix-installer-action/pull/87](https://togithub.com/DeterminateSystems/nix-installer-action/pull/87) - Update action.yml description for source-url by [@​lucperkins](https://togithub.com/lucperkins) in [https://github.com/DeterminateSystems/nix-installer-action/pull/89](https://togithub.com/DeterminateSystems/nix-installer-action/pull/89) - Provide new test matrix for source-\* inputs by [@​lucperkins](https://togithub.com/lucperkins) in [https://github.com/DeterminateSystems/nix-installer-action/pull/91](https://togithub.com/DeterminateSystems/nix-installer-action/pull/91) - Disable docker under act by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/90](https://togithub.com/DeterminateSystems/nix-installer-action/pull/90) - Update detsys-ts by [@​lucperkins](https://togithub.com/lucperkins) in [https://github.com/DeterminateSystems/nix-installer-action/pull/93](https://togithub.com/DeterminateSystems/nix-installer-action/pull/93) - tests: make megajob block on failure by [@​cole-h](https://togithub.com/cole-h) in [https://github.com/DeterminateSystems/nix-installer-action/pull/96](https://togithub.com/DeterminateSystems/nix-installer-action/pull/96) - Srv update by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/97](https://togithub.com/DeterminateSystems/nix-installer-action/pull/97) - Update detsys-ts (status page changes) by [@​lucperkins](https://togithub.com/lucperkins) in [https://github.com/DeterminateSystems/nix-installer-action/pull/98](https://togithub.com/DeterminateSystems/nix-installer-action/pull/98) **Full Changelog**: DeterminateSystems/nix-installer-action@v11...v12 ### [`v11`](https://togithub.com/DeterminateSystems/nix-installer-action/releases/tag/v11) [Compare Source](https://togithub.com/DeterminateSystems/nix-installer-action/compare/v10...v11) #### What's Changed - Rebase on top of detsys-ts for abstracting over install.determinate.systems by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/74](https://togithub.com/DeterminateSystems/nix-installer-action/pull/74) - Update detsys-ts by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/75](https://togithub.com/DeterminateSystems/nix-installer-action/pull/75) - Gracefully handle FlakeHub login failure by [@​cole-h](https://togithub.com/cole-h) in [https://github.com/DeterminateSystems/nix-installer-action/pull/77](https://togithub.com/DeterminateSystems/nix-installer-action/pull/77) - General JS cleanup by [@​lucperkins](https://togithub.com/lucperkins) in [https://github.com/DeterminateSystems/nix-installer-action/pull/76](https://togithub.com/DeterminateSystems/nix-installer-action/pull/76) - Fix broken CI caused by Nix reinstallation wiping out the Magic Nix Cache by [@​lucperkins](https://togithub.com/lucperkins) in [https://github.com/DeterminateSystems/nix-installer-action/pull/79](https://togithub.com/DeterminateSystems/nix-installer-action/pull/79) - Standardize on v4 of the checkout action by [@​lucperkins](https://togithub.com/lucperkins) in [https://github.com/DeterminateSystems/nix-installer-action/pull/80](https://togithub.com/DeterminateSystems/nix-installer-action/pull/80) - Switch to tsup for building by [@​lucperkins](https://togithub.com/lucperkins) in [https://github.com/DeterminateSystems/nix-installer-action/pull/82](https://togithub.com/DeterminateSystems/nix-installer-action/pull/82) - Update dependencies by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/85](https://togithub.com/DeterminateSystems/nix-installer-action/pull/85) **Full Changelog**: DeterminateSystems/nix-installer-action@v10...v11 ### [`v10`](https://togithub.com/DeterminateSystems/nix-installer-action/releases/tag/v10) [Compare Source](https://togithub.com/DeterminateSystems/nix-installer-action/compare/v9...v10) #### What's Changed - action: post-run-job: try clean daemon container, warn on failure by [@​colemickens](https://togithub.com/colemickens) in [https://github.com/DeterminateSystems/nix-installer-action/pull/61](https://togithub.com/DeterminateSystems/nix-installer-action/pull/61) - No longer require sudo by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/64](https://togithub.com/DeterminateSystems/nix-installer-action/pull/64) - Handle docker not existing. by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/66](https://togithub.com/DeterminateSystems/nix-installer-action/pull/66) - Don't use docker shim if only using a mounted docker.sock instead of docker-in-docker by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/67](https://togithub.com/DeterminateSystems/nix-installer-action/pull/67) - DETERMINATE_NIX_KVM fixup, support Magic Nix Cache + FlakeHub Cache on Namespace runners by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/72](https://togithub.com/DeterminateSystems/nix-installer-action/pull/72) **Full Changelog**: DeterminateSystems/nix-installer-action@v9...v10 ### [`v9`](https://togithub.com/DeterminateSystems/nix-installer-action/releases/tag/v9) [Compare Source](https://togithub.com/DeterminateSystems/nix-installer-action/compare/v8...v9) #### What's Changed - Support GitHub Enterprise Server in the access-token config. by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/58](https://togithub.com/DeterminateSystems/nix-installer-action/pull/58) - Support GitHub Enterprise Server using ARC by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/59](https://togithub.com/DeterminateSystems/nix-installer-action/pull/59) **Full Changelog**: DeterminateSystems/nix-installer-action@v8...v9 ### [`v8`](https://togithub.com/DeterminateSystems/nix-installer-action/releases/tag/v8) [Compare Source](https://togithub.com/DeterminateSystems/nix-installer-action/compare/v7...v8) Enables KVM out of the box, for snappy NixOS VM tests. #### What's Changed - KVM support out of the box, plus a refreshed README by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/56](https://togithub.com/DeterminateSystems/nix-installer-action/pull/56) **Full Changelog**: DeterminateSystems/nix-installer-action@v7...v8 ### [`v7`](https://togithub.com/DeterminateSystems/nix-installer-action/releases/tag/v7) [Compare Source](https://togithub.com/DeterminateSystems/nix-installer-action/compare/v6...v7) This release should reduce or eliminate `ETXTBSY` related errors by relying on the official Github Actions [tool cache](https://togithub.com/actions/toolkit/tree/master/packages/tool-cache). This tool cache includes retry support if a download request fails. On [Namespace Runners](https://cloud.namespace.so/docs/features/faster-github-actions) the action should correctly detect that `--init none` must be passed to the installer. #### What's Changed - .github: allow trigger ci manually by [@​colemickens](https://togithub.com/colemickens) in [https://github.com/DeterminateSystems/nix-installer-action/pull/45](https://togithub.com/DeterminateSystems/nix-installer-action/pull/45) - main.ts: fixup logic to ensure only one installer url override is set by [@​colemickens](https://togithub.com/colemickens) in [https://github.com/DeterminateSystems/nix-installer-action/pull/44](https://togithub.com/DeterminateSystems/nix-installer-action/pull/44) - Retry (w/ back-off) downloading the installer binary by [@​colemickens](https://togithub.com/colemickens) in [https://github.com/DeterminateSystems/nix-installer-action/pull/46](https://togithub.com/DeterminateSystems/nix-installer-action/pull/46) - Add check for dist folder by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/48](https://togithub.com/DeterminateSystems/nix-installer-action/pull/48) - fix: end the FileStreamWriter for the installer file by [@​colemickens](https://togithub.com/colemickens) in [https://github.com/DeterminateSystems/nix-installer-action/pull/47](https://togithub.com/DeterminateSystems/nix-installer-action/pull/47) - eslint/tsconfig: validate no floating Promises, adjust tsconfig by [@​colemickens](https://togithub.com/colemickens) in [https://github.com/DeterminateSystems/nix-installer-action/pull/49](https://togithub.com/DeterminateSystems/nix-installer-action/pull/49) - Detect whether we're running in a Namespace runner, and if so, set `init: none` by [@​hugosantos](https://togithub.com/hugosantos) in [https://github.com/DeterminateSystems/nix-installer-action/pull/52](https://togithub.com/DeterminateSystems/nix-installer-action/pull/52) - Use Github Actions provided tool cache and exec by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/53](https://togithub.com/DeterminateSystems/nix-installer-action/pull/53) #### New Contributors - [@​colemickens](https://togithub.com/colemickens) made their first contribution in [https://github.com/DeterminateSystems/nix-installer-action/pull/45](https://togithub.com/DeterminateSystems/nix-installer-action/pull/45) - [@​hugosantos](https://togithub.com/hugosantos) made their first contribution in [https://github.com/DeterminateSystems/nix-installer-action/pull/52](https://togithub.com/DeterminateSystems/nix-installer-action/pull/52) **Full Changelog**: DeterminateSystems/nix-installer-action@v6...v7 ### [`v6`](https://togithub.com/DeterminateSystems/nix-installer-action/releases/tag/v6) [Compare Source](https://togithub.com/DeterminateSystems/nix-installer-action/compare/v5...v6) Update to node20 #### What's Changed - Update the action to use node20 by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/41](https://togithub.com/DeterminateSystems/nix-installer-action/pull/41) **Full Changelog**: DeterminateSystems/nix-installer-action@v5...v6 ### [`v5`](https://togithub.com/DeterminateSystems/nix-installer-action/releases/tag/v5) [Compare Source](https://togithub.com/DeterminateSystems/nix-installer-action/compare/v4...v5) Support for Act, and beta support for private Flakes on FlakeHub #### What's Changed - Update README.md to say v4 by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/27](https://togithub.com/DeterminateSystems/nix-installer-action/pull/27) - Add act support by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/30](https://togithub.com/DeterminateSystems/nix-installer-action/pull/30) - \--nix-build-user-base and --nix-build-user-prefix logic no longer confused by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/32](https://togithub.com/DeterminateSystems/nix-installer-action/pull/32) - Fix specifying a custom planner by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/35](https://togithub.com/DeterminateSystems/nix-installer-action/pull/35) - Typescript rewrite by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/34](https://togithub.com/DeterminateSystems/nix-installer-action/pull/34) - Post run diagnostics by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/39](https://togithub.com/DeterminateSystems/nix-installer-action/pull/39) - Support private flakes on FlakeHub by [@​grahamc](https://togithub.com/grahamc) in [https://github.com/DeterminateSystems/nix-installer-action/pull/38](https://togithub.com/DeterminateSystems/nix-installer-action/pull/38) **Full Changelog**: DeterminateSystems/nix-installer-action@v4...v5 ### [`v4`](https://togithub.com/DeterminateSystems/nix-installer-action/releases/tag/v4) [Compare Source](https://togithub.com/DeterminateSystems/nix-installer-action/compare/v3...v4) #### What's Changed - Update example in README to use v3 by [@​ajaxbits](https://togithub.com/ajaxbits) in [https://github.com/DeterminateSystems/nix-installer-action/pull/25](https://togithub.com/DeterminateSystems/nix-installer-action/pull/25) - Add a ?ci=github to GHA requests, to help us test GHA-specific fixes more quickly and perform more controlled roll-outs of new releases. [https://github.com/DeterminateSystems/nix-installer-action/pull/26](https://togithub.com/DeterminateSystems/nix-installer-action/pull/26) #### New Contributors - [@​ajaxbits](https://togithub.com/ajaxbits) made their first contribution in [https://github.com/DeterminateSystems/nix-installer-action/pull/25](https://togithub.com/DeterminateSystems/nix-installer-action/pull/25) **Full Changelog**: DeterminateSystems/nix-installer-action@v3...v4 ### [`v3`](https://togithub.com/DeterminateSystems/nix-installer-action/releases/tag/v3) [Compare Source](https://togithub.com/DeterminateSystems/nix-installer-action/compare/v2...v3) A minor release to address [https://github.com/DeterminateSystems/nix-installer-action/issues/21](https://togithub.com/DeterminateSystems/nix-installer-action/issues/21). #### What's Changed - v0.9.0 - nix profile location change by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/22](https://togithub.com/DeterminateSystems/nix-installer-action/pull/22) - In GHA use Hello instead of fortune by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/23](https://togithub.com/DeterminateSystems/nix-installer-action/pull/23) **Full Changelog**: DeterminateSystems/nix-installer-action@v2...v3 ### [`v2`](https://togithub.com/DeterminateSystems/nix-installer-action/releases/tag/v2) [Compare Source](https://togithub.com/DeterminateSystems/nix-installer-action/compare/v1...v2) #### What's Changed - Add missing setting to README table by [@​lucperkins](https://togithub.com/lucperkins) in [https://github.com/DeterminateSystems/nix-installer-action/pull/14](https://togithub.com/DeterminateSystems/nix-installer-action/pull/14) - README: use tagged release by [@​cole-h](https://togithub.com/cole-h) in [https://github.com/DeterminateSystems/nix-installer-action/pull/17](https://togithub.com/DeterminateSystems/nix-installer-action/pull/17) - add option to change diagnostic endpoint by [@​Mic92](https://togithub.com/Mic92) in [https://github.com/DeterminateSystems/nix-installer-action/pull/16](https://togithub.com/DeterminateSystems/nix-installer-action/pull/16) - Reflect removal of channels in upcoming version by [@​cole-h](https://togithub.com/cole-h) in [https://github.com/DeterminateSystems/nix-installer-action/pull/18](https://togithub.com/DeterminateSystems/nix-installer-action/pull/18) - Reflect v0.6.0 changes by [@​Hoverbear](https://togithub.com/Hoverbear) in [https://github.com/DeterminateSystems/nix-installer-action/pull/19](https://togithub.com/DeterminateSystems/nix-installer-action/pull/19) #### New Contributors - [@​Mic92](https://togithub.com/Mic92) made their first contribution in [https://github.com/DeterminateSystems/nix-installer-action/pull/16](https://togithub.com/DeterminateSystems/nix-installer-action/pull/16) **Full Changelog**: DeterminateSystems/nix-installer-action@v1...v2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/dc-tec/nixvim). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
detsys-pr-bot
pushed a commit
to detsys-pr-bot/nix-installer-action
that referenced
this pull request
Aug 26, 2024
…m DeterminateSystems/use-coalesce-for-array` (`e8f6e8f54d85aa0fd3d0b694dd3279a21497a33b`)
grahamc
added a commit
that referenced
this pull request
Aug 26, 2024
…ms/use-coalesce-for-array` (`e8f6e8f54d85aa0fd3d0b694dd3279a21497a33b`) (#117) Co-authored-by: grahamc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This:
I say attempts because I haven't managed to hit this soft-failure path at all with GHA. I've done maybe a dozen runs, each of which containing 2 NS runs, and I've only seen happy path so far.
However, given a careful review, I think this change is still an improvement and safe to merge and iterate on whenever we see this actually repro in the wild.
Checklist