Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface for Date and Time Data Source #130

Open
nilshoerrmann opened this issue Feb 14, 2013 · 1 comment
Open

Interface for Date and Time Data Source #130

nilshoerrmann opened this issue Feb 14, 2013 · 1 comment

Comments

@nilshoerrmann
Copy link
Contributor

The bundled date and time Data Source should be transformed into an Data Source interface: this way the language settings will no longer have to reside in the config but will be stored in a Data Source file that can be tracked with Git and shared via the workspace folder.

In this context, the starting weekday can be made configurable – this would fix #129.
Also, the month and week names should be provided by the PHP DateTime class – this potentially fixes #127.
@nilshoerrmann nilshoerrmann mentioned this issue Apr 5, 2013
Closed
nilshoerrmann referenced this issue Nov 22, 2014
@nitriques
Make sure we are consistent with format in DS
420841e 
@PascalPiche came across this bug while displaying the weekday name: The DS formats the weekday with 'N', which uses ISO-8601 (first date of the week is then Monday as in the US, not Sunday).

There were multiple places where a fix could be applied, but the best solutions we found was to apply the fix in the data-source for two reasons:

1. Field ouput won't change, so less risk to break things
2. The xsl template is agnostic to this change since it was doing string matches
@nitriques
Copy link
Member

I would make it abstract instead of an interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nilshoerrmann @nitriques