Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make sure we are consistent with format in DS
@PascalPiche came across this bug while displaying the weekday name: The DS formats the weekday with 'N', which uses ISO-8601 (first date of the week is then Monday as in the US, not Sunday). There were multiple places where a fix could be applied, but the best solutions we found was to apply the fix in the data-source for two reasons: 1. Field ouput won't change, so less risk to break things 2. The xsl template is agnostic to this change since it was doing string matches
- Loading branch information
420841e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this actually solving?
420841e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The datetime xsl template was rendering one day off. Like today was Thrusday nov 22, which is wrong.
420841e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I'll have to think about the sideeffects of this change.
420841e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please do! The only one I've found was that if you did apply-templates on the weekdays (to create some kind of calendar), then the order would change. If not, I could not find another side effect.
420841e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the change is fine for now, but we should implement #130 with a proper setting.
420841e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!