chore: add safety around start() in EventSource #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
L-Joli
commented
Aug 11, 2023
L-Joli
commented
- add safety around start() in EventSource to catch exception
jsalaber
reviewed
Aug 11, 2023
| DevCycleLogger.i("Starting EventSource client using URI: %s", url); | ||
|
|
||
| streamExecutor.execute(() -> { | ||
| try { |
There was a problem hiding this comment.
are both of these try catches necessary?
There was a problem hiding this comment.
hmmm...I'm thinking they could catch more specific exceptions like if the executor rejects the task (RejectedExecutionException) and general Exception during run(). Do you think I should only keep one? Also, should I actually log the entire exception instead of just the message?🤔
There was a problem hiding this comment.
couldn't you catch general exceptions at the top level and log based on the type?
L-Joli
force-pushed
the
DVC-8476-crashes-investigation
branch
from
4280ec9
to
20b97ab
Compare
jsalaber
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.