Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ExpressionCompiler from AmbiguousMatchException when source class has overridden base property with other data types #581

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

mpreyskurantov
Copy link
Contributor

Fixes #580

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Base: 97.19% // Head: 97.16% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (f3311ea) compared to base (3f7aaa6).
Patch coverage: 93.33% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
- Coverage   97.19%   97.16%   -0.03%     
==========================================
  Files          55       55              
  Lines        2243     2257      +14     
==========================================
+ Hits         2180     2193      +13     
- Misses         63       64       +1     
Impacted Files Coverage Δ
net/DevExtreme.AspNet.Data/ExpressionCompiler.cs 96.70% <93.33%> (-0.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mpreyskurantov mpreyskurantov merged commit 1dcc20e into DevExpress:master Jan 26, 2023
@mpreyskurantov mpreyskurantov deleted the AmbiguousMatch branch January 26, 2023 13:31
@mpreyskurantov mpreyskurantov changed the title ReTry to find inherited property by BindingFlags.DeclaredOnly Prevent ExpressionCompiler from AmbiguousMatchException when source class has overridden base property with other data types Jan 26, 2023
@mpreyskurantov mpreyskurantov added the .NET Pull requests that update .net code label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Pull requests that update .net code
Projects
None yet
3 participants