QUnit: Extensions refactoring (#11645, #11765, #11843) #11861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # testing/.eslintrc # testing/tests/DevExpress.viz.sparklines/baseSparklineTooltipEvents.tests.js
* QUnit: Refactor to use one way for ignoring uncleared timers * QUnit: Get rid of timerIgnoringCheckers.applyUnregister method * QUnit: timerIgnoringCheckers -> timersDetector.ignoreRules * QUnit: ignoreRules.needSkip -> ignoreRules.shouldIgnore * QUnit: Get rid of ignoreAngularBrowserDeferTimer duplication * QUnit: Refactor isThirdPartyLibraryTimer * QUnit: Get rid of normalizedTimerInfo * QUnit: Refactor spyWindowMethods * QUnit: Consolidate all ignore rules for angular in one place * QUnit: Log test failure when uncleared timers detected instead of global one # Conflicts: # testing/helpers/qunitExtensions.js
San4es
force-pushed
the
qunit-extensions-refactoring
branch
from
ddeb9cd
to
a671162
Compare
San4es
force-pushed
the
qunit-extensions-refactoring
branch
from
a671162
to
f6eb06d
Compare
nightskylark
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #11645, #11765 and #11843.