Chat: data layer integration #28114
Merged
Chat: data layer integration #28114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeniyKiyashko
force-pushed
the
24_2_chat_datasource_integration
branch
3 times, most recently
from
a86764b
to
349f24e
Compare
EugeniyKiyashko
force-pushed
the
24_2_chat_datasource_integration
branch
from
349f24e
to
d9138fb
Compare
EugeniyKiyashko
force-pushed
the
24_2_chat_datasource_integration
branch
from
f0789ff
to
04d9ba2
Compare
ksercs
reviewed
Sep 30, 2024
packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/chat.tests.js
Show resolved
Hide resolved
ksercs
previously approved these changes
Sep 30, 2024
ksercs
reviewed
Sep 30, 2024
| } | ||
|
|
||
| dataSource.store().insert(message).done(() => { | ||
| dataSource.load(); |
There was a problem hiding this comment.
Is it required? Seems like it means that we'll send addition request after single message rendering, so it would be great if we can omit it
There was a problem hiding this comment.
We discussed this part separately. The details can be found in the corresponding team's post.
ksercs
approved these changes
Oct 1, 2024
Zedwag
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.