fix Authorization Header is removed even if it should not (close #1016)
#1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @VasilyStrelyaev |
churkin
suggested changes
Jan 26, 2017
| if (typeof header === 'string' && AUTHORIZATION.headers.indexOf(header.toLowerCase()) !== -1) | ||
| value = AUTHORIZATION.valuePrefix + value; | ||
|
|
||
| nativeMethods.xhrSetRequestHeader.call(this, header, value); |
| /* eslint hammerhead/proto-methods: 2 */ | ||
|
|
||
| export default { | ||
| valuePrefix: 'hammerhead-prefix-by-client', |
There was a problem hiding this comment.
hammerhead-prefix-by-client --> hammerhead|prefix|by-client
| if (this.readyState === this.DONE) { | ||
| var headers = JSON.parse(this.responseText); | ||
|
|
||
| Object.keys(headers).forEach(function (header) { |
There was a problem hiding this comment.
Just check 4 headers, without foreach function
| it('Should pass authorization headers which are defined by client for cross-domain request without credentials (GH-1016)', function (done) { | ||
| var options = { | ||
| url: proxy.openSession('http://127.0.0.1:2002/echo-headers-with-credentials', session), | ||
| headers: AUTHORIZATION.headers.reduce(function (obj, header, index) { |
There was a problem hiding this comment.
Use more simple code - without reduce, set all headers manualy
|
❌ Tests for the commit 2d4aba0 have failed. See details: |
VasilyStrelyaev
approved these changes
Jan 26, 2017
|
✅ Tests for the commit 1081636 have passed. See details: |
churkin
approved these changes
Jan 27, 2017
miherlosev
approved these changes
Jan 27, 2017
AndreyBelym
pushed a commit
to AndreyBelym/testcafe-hammerhead
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @churkin @miherlosev