Incorrect resizeToFitDevice on mac with portaitOrientation=true

[kirovboris]

fixture('React').page('https://facebook.github.io/react/');

test('Resize to fit device', async t => {
    await t.resizeWindowToFitDevice('Nexus 7 (2013)', { portraitOrientation: true });

    const getWindowHeight = ClientFunction(() => window.innerHeight);
    const getWindowWidth  = ClientFunction(() => window.innerWidth);

    expect(await getWindowHeight()).eql(960);
    expect(await getWindowWidth()).eql(600);
});

AssertionError: expected 896 to deeply equal 960

[AndreyBelym]

We cannot resize a window to the size bigger than the desktop size on Mac. Can you specify your Mac desktop size as well?

[inikulin]

@AndreyBelym Maybe we could give warning in that case?

[AndreyBelym]

Sure!

[AndreyBelym]

Browser provider API changes:

canResizeWindowToDimensions(browserId, width, height)

Allows to validate the specified width and height of browser window browserId before the actual resize. The result is true if browser window can be resized to the specified dimensions, false otherwise. In case of false value TestCafe will stop resizing and throw an error.

hasCustomActionForBrowser(browserId)

Enables feature querying for the specified browser window browserId. The function should return an object with the following properties:
hasResizeWindow - the browser window supports resizing,
hasMaximizeWindow - the browser window supports maximizing,
hasTakeScreenshots - the browser window image can be captured to the file,
hasCanResizeWindowToDimensions - the requested window dimensions can be validated before resize.

If a property in the returned object has the true value, the provider should have an implemented function with the name corresponding to the property. (e.g. hasTakeScreenshot => takeScreenshot). The default implementation for hasCustomActionForBrowser checks for the function names by calling hasOwnProperty on provider object.

isLocalBrowser(browserId)

Returns true if the specified browser browserId is a local browser. Default implementation ignores browserId and always returns false.

[lock]

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.