Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full-Height-Bird-Box #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Markshall
Copy link

This is my first time doing a PR, so excuse my mistakes if I have made any!

When I visited the GH-Pages branch on DevTip's Parallax on the Web series, I noticed the .bird-box wasn't the same size as the window height, thus leaving a bit of white space at the bottom which I didn't like, such as the image below:

screenshot_2

These two simple code fixes change that, as it sets .bird-box to the same height as the window in functions.js, and then changes the background-size property value to 'cover'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant