Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify landing elements logic #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrsl-dev
Copy link

@jrsl-dev jrsl-dev commented Dec 8, 2015

You're probably not taking pull request for this any more but I finally got around to watching this series and thought I'd toss in my two cents. PR #24 does something similar but creates a variable that isn't really needed. jQuery provides you the current element already, so why not use it!

Great series! Thanks for your hard work, hoping Google is going well!

Removes extra dom query in favor of passing the current element in the
iteration into the function. Also removes the eq call since that is
taken care of by the iteration itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant