Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added QR Code reader / generator tool #1012

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Added QR Code reader / generator tool #1012

merged 1 commit into from
Jan 3, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Dec 26, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #270

What is the new behavior?

  1. Added a QR Code Generator / Reader tool. User can generate a QR Code as the user change the "Text" field. User can also read a QR Code appearing on an image.
  2. Modified IUIImageViewer to support custom handling of "Save As" for a given file extension. This is needed in order to save the QR Code as "SVG". The reason for it is that only XZing (library used for generating the QR Code) can know how a SVG can be generated from the input text.

Other information

image

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler requested a review from btiteux December 26, 2023 06:21
@veler veler linked an issue Dec 26, 2023 that may be closed by this pull request
@veler veler merged commit d0db491 into dev/2.0 Jan 3, 2024
@veler veler deleted the dev/2.0-qrcode branch January 3, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QR Code Generator & Reader
2 participants