Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Hero header on All Tools page #1016

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

veler
Copy link
Collaborator

@veler veler commented Jan 3, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

All Tools page isn't personalized. The whole app feels a little bit too "generic".

What is the new behavior?

Recording.2024-01-02.200126.mp4

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler added the devtoys-v2.0 DevToys v2.0 label Jan 6, 2024
Copy link
Collaborator

@btiteux btiteux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, sorry for the late review. It's good for me with the new colors 😁

@veler veler merged commit 0a67f61 into dev/2.0 Jan 9, 2024
@veler veler deleted the dev/2.0-custom-welcome-page branch January 9, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtoys-v2.0 DevToys v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants