Added localized error message and error parsing for base number type #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veler
approved these changes
Dec 5, 2021
| using System.Globalization; | ||
| using System.Linq; |
There was a problem hiding this comment.
Oh I didn't see this one
|
Oops, can you please fix the unit tests?
|
veler
pushed a commit
that referenced
this pull request
Mar 31, 2023
…103) * added localized error message and error parsing for base number type * removed unused using and added comment * refactoring RemoveFormatting for NumberBaseFormatter. * handle max value for hexadecimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The user can type any character in the input field
What is the new behavior?
If the user type an invalid character in the input field. The user will see a localized error message.
Other information
Quality check
Before creating this PR, have you: