Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where SVG icons were flickering when the NavigationView was collapsed. #109

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

veler
Copy link
Collaborator

@veler veler commented Dec 11, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

When the NavigationView is collapsed, SVG icons may be flickering.

What is the new behavior?

Fixed the issue by limiting the icon size change.
Additionally, reduced the amount of access to the hard drive when rendering the icons.

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler requested a review from btiteux December 11, 2021 18:30
@veler veler added the bug Something isn't working label Dec 11, 2021
@veler veler merged commit 39c0cba into main Dec 11, 2021
@veler veler deleted the fix-icon-flickering branch December 11, 2021 20:39
veler added a commit that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant