Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where the app wrongly detect an update #1204

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

veler
Copy link
Collaborator

@veler veler commented Jun 12, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

DevToys current version is v2.0-preview.1. We recently dropped the Revision number (4th digit) because the MS Store and Homebrew only accept 3 digits version number. This regressed the update detection.

GitHub release is "v2.0.1.0", which is parsed as a System.Version(2, 0, 1, 0).
DevToys running version is "v2.0-preview.1", which is parsed as System.Version(2, 0, 1, -1).

Because of this, DevToys finds that there's a newer version on GitHub, which is wrong.

What is the new behavior?

We now only check the first 3 digits (Major, Minor, Build).

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler veler requested a review from btiteux June 12, 2024 03:05
@veler veler merged commit 81baa84 into main Jun 17, 2024
3 checks passed
@veler veler deleted the fixUpdateCheck branch June 17, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants