Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an issue where the clipboard content isn't preserved after shutting down the app. #24

Merged
merged 2 commits into from
Oct 10, 2021
Merged

Fixed an issue where the clipboard content isn't preserved after shutting down the app. #24

merged 2 commits into from
Oct 10, 2021

Conversation

veler
Copy link
Collaborator

@veler veler commented Oct 10, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

When copying something from a text box of rich edit box and then shutting down the app, the clipboard is cleared out, making it impossible to paste the data to another app after shutting down DevToys.
This issue doesn't reproduce with Monaco Editor.

Issue Number: #22

What is the new behavior?

Other information

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler
Revert "Revert "Fixed an issue where the clipboard content isn't pres…
143c2c9 
…erved after shutting down the app.""

This reverts commit 502c629.
@veler veler added the bug Something isn't working label Oct 10, 2021
@veler veler requested a review from btiteux October 10, 2021 06:30
@veler veler linked an issue Oct 10, 2021 that may be closed by this pull request
Clipboard isn't preserved after shutting down DevToys #22
Closed
@btiteux btiteux merged commit f70bbf3 into main Oct 10, 2021
@btiteux btiteux deleted the clipboard-fix branch October 10, 2021 15:52
veler added a commit that referenced this pull request Mar 31, 2023
@veler
Fixed an issue where the clipboard content isn't preserved after shut…
957a986 
…ting down the app. (#24)

* Revert "Revert "Fixed an issue where the clipboard content isn't preserved after shutting down the app.""

This reverts commit 502c629.

* flush clipboard in Cut command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btiteux btiteux Awaiting requested review from btiteux

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clipboard isn't preserved after shutting down DevToys
2 participants
@veler @btiteux