Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev 2.0] Added DropDownList, ComboBox and improved ScrollViewer #856

Merged
merged 7 commits into from
Jun 17, 2023

Conversation

veler
Copy link
Collaborator

@veler veler commented Jun 11, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

  1. DevToys 2.0 was missing a DropDownList.
  2. DevToys 2.0 was missing a ComboBox.
  3. I was unhappy with ScrollViewer we had so far. An issue in WebView2 in WPF (issue doesn't repro in WASDK or Safari (MAUI on Mac)) cause the scrollbar's width change on mouse hover to shift the content of the scrollviewer. See video below:
Recording.2023-06-10.215230.mp4

What is the new behavior?

  • Added a DropDownList
  • Added a ComboBox
  • Adopted SimpleBar library for the scrollbar. This library replies on the native scrollbars of the web browser but replace their design. This is different than JavaScript libraries that "emulate" the scrollbar. Here, we keep the smoothness of the native scrollbars of the web browser.

Other information

Recording.2023-06-10.215634.mp4

image

image

image

Quality check

Here is a known issue. Will be addressed later

image

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler requested a review from btiteux June 11, 2023 04:59
@veler veler changed the title [Dev 2.0] Added DropDownList and improved ScrollViewer [Dev 2.0] Added DropDownList, ComboBox and improved ScrollViewer Jun 11, 2023
@veler veler merged commit a4551eb into dev/2.0 Jun 17, 2023
@veler veler deleted the dev/2.0-drop-down-list branch June 17, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant