-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added hex converter toys #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall :) Thank you so much! :D
|
||
public bool CanBeTreatedByTool(string data) | ||
{ | ||
return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we could detect binaries and hexadecimal automatically. I can't think of any other tool where binaries and hex would be pasted, so perhaps it would be cool to be able to leverage Smart Detection in these scenario.
src/dev/impl/DevToys/ViewModels/Tools/HexConverter/HexConverterToolViewModel.cs
Outdated
Show resolved
Hide resolved
* Added hexconverter toy * added french localization and Accessibility name * renamed HexConverter to NumberBaseConverter * cleaned csproj *.resw
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
DevToys doesn't have a tool to convert number between different base.
Issue Number: #18
What is the new behavior?
Other information
Quality check
Before creating this PR, have you: