This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Fix for 400 bad request from Binance #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge (release 1.10.817)
|
I think we are also not inserting a correct since value. Can someone check this? |
DeviaVir
approved these changes
Feb 1, 2018
|
@Shawn8901 Not sure how the date range is working but it seems to be passed correctly. Here is what I see when running backfill with different days on unstable branch |
Shawn8901
referenced
this pull request
Feb 2, 2018
…ce (#1268) Also the since argument must be type of undefined see: https://github.com/ccxt/ccxt/blob/master/js/binance.js#L747
Heerpa
pushed a commit
to Heerpa/zenbot
that referenced
this pull request
Feb 25, 2018
…nge (release 1.10.817) (DeviaVir#1256)
This was referenced Mar 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCXT lib update forced this change (release 1.10.817). Fixes 1254