Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Kraken: Rate limiting for backfilling and warning instead of error on API retries #216

Closed
wants to merge 30 commits into from
Closed

Kraken: Rate limiting for backfilling and warning instead of error on API retries #216

wants to merge 30 commits into from

Conversation

crubb
Copy link
Contributor

@crubb crubb commented Jun 3, 2017

@DeviaVir

Addressing comments from #177.

Alexandre-io and others added 30 commits May 26, 2017 18:47
@Alexandre-io
Add kraken support
586bb69
@nibzo1
Fixing some misplaced variables
2a28d62 
Some variables were incorrect
@Alexandre-io
Merge pull request #1 from nibzo1/feat/kraken
92b8bc3 
Fixing some misplaced variables
@Alexandre-io
fix trade time
c1646c6
@Alexandre-io
better error handling
13ae46f
@Alexandre-io
Fix getOrder && trade
5e9f49a
Added default config options, fix trade and error reporting
ba274c5
@crubb
Merge branch 'feat/kraken' into feat/kraken
287f27b
@Alexandre-io
Remove debug
d46cdae
@Alexandre-io
Merge branch 'feat/kraken' into feat/kraken
d914037
@Alexandre-io
Merge pull request #2 from crubb/feat/kraken
0fb0790 
Added default config options, fix trade and error reporting
Remove retries
47693ab
- getOrders now working & reporting closed orders properly
5bfa8cc 
- Retry now only on ETIMEDOUT
@Alexandre-io
Merge pull request #3 from crubb/feat/kraken
2f637c4 
getOrder working, and properly(?) handling retries now
@crubb
More error handling for recoverable/reconnect errors and trade
ad55946
@Alexandre-io
Merge pull request #4 from crubb/feat/kraken
841fb51 
More error handling for recoverable/reconnect errors and trade
@Alexandre-io
Fix errors matching
d6367e4
@Alexandre-io
Fix retry
75a4a62
@crubb
More verbose retries (we need to eliminate them! ;))
813c86e 
Adjusted minimum order size according to https://support.kraken.com/hc/en-us/articles/205893708-What-is-the-minimum-order-size-
@crubb
Merge with timeout of 2.5s
4b7dbc3 
Merge branch 'feat/kraken' of https://github.com/Alexandre-io/zenbot into feat/kraken

Conflicts:
	extensions/kraken/exchange.js
@crubb
Adjust to an earlier upstream change
1bbde4a
@crubb
Merge https://github.com/carlos8f/zenbot into feat/kraken
2e39f93
@crubb
Longer retries when hitting API rate limit and retry() also for getTr…
d2975e6 
…ades
@crubb
Borrowed order caching from extensions/poloniex/
9965103
@crubb
It's min_size: 0.01 and not min_total...
1dd61ef
@crubb
update-products.sh for min_size
4bbf666
@crubb
Added logic for post only orders (handled differently by Kraken), add…
a90a12f 
…ed Kraken to README and removed ; at end of lines
@crubb
Removed more ;
e851647
@crubb
Merge https://github.com/carlos8f/zenbot into feat/kraken
32edc75
@crubb
Kraken: Rate limiting for backfilling and warning instead of error on…
6632c7e 
… API retries
@crubb
Copy link
Contributor Author

crubb commented Jun 3, 2017

Sorry, "dirty" branch.

@crubb crubb closed this Jun 3, 2017
@DeviaVir
Copy link
Owner

DeviaVir commented Jun 3, 2017

@crubb I would squash and merge so it's not a big difference to me. If you want to fix it (just in case you're not sure how):

git remote add upstream [email protected]:carlos8f/zenbot.git 
git fetch upstream
git checkout master
git merge --no-ff upstream/master
# master is now up to date with carlos8f
git checkout -b my-new-branch # or just git checkout your thing
git merge --no-ff master
# this either ends up in a bunch of conflicts (making it easier to just create a new branch entirely) or you will end up with a nice clean branch to push

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crubb @DeviaVir @nibzo1 @Alexandre-io