This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Bitfinex extension PR #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviaVir
previously approved these changes
Jun 8, 2017
conf-sample.js
Outdated
| c.bitfinex.key = 'YOUR-API-KEY' | ||
| c.bitfinex.secret = 'YOUR-SECRET' | ||
| // May use 'exchange' or 'trading' wallet balances. However margin trading may not work...read | ||
| the API documentation. |
|
|
||
| function authedClient () { | ||
| if (!authed_client) { | ||
| if (!c.bitfinex.key || c.bitfinex.key === 'YOUR-API-KEY') { |
| var exchange = { | ||
| name: 'bitfinex', | ||
| // historyScan: 'backward', | ||
| makerFee: 0.1, |
There was a problem hiding this comment.
could you add takerFee too? (via #233)
| opts.type = 'exchange limit' | ||
| } | ||
| else if (c.bitfinex.wallet === 'trading' && typeof opts.type === 'undefined') { | ||
| opts.type = 'limit' |
There was a problem hiding this comment.
ref #233 again, could you add a check for order_type (if bitfinex supports it) and use market orders when people supply taker? not a must, just a "would be nice"
DeviaVir
dismissed
their stale review
should really fix the missing // before approval
|
Merging this in so people can start to play with this and more feedback can find its way to this repo. |
supersabbath
pushed a commit
to supersabbath/zenbot
that referenced
this pull request
Oct 2, 2017
* Add files via upload * Delete bitfinex-master.zip * Create package.json * final version * Bitfinex API credentials * Bitfinex deps * // fix * add takerFee Support ref DeviaVir#233. Did not test after update as master is not update to DeviaVir#233 * move to /
This was referenced Aug 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final version.