This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Add support for QuadrigaCX API #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Docker for Windows
Quadriga API public and private queries are working, testing the getQuote and getBalance.
* Fix bug in buy function (typo) prevent callback * Change formatting to follow the rest of zenbot
There is a general fall through to setTimer at the end of the function that must always run, the conditionals were causing additional uncessary checks which increases probability of hitting API rate limits.
|
Accidentally closed, sorry |
cmroche
commented
Jun 29, 2017
DeviaVir
suggested changes
Jun 30, 2017
| } | ||
|
|
||
| if (err) return retry('getTrades', func_args, err) | ||
| if (trades.error) return retry('getTrades', func_args, trades.error) |
| var client = authedClient() | ||
| client.api('balance', function(err, wallet) { | ||
| if (err) return retry('getBalance', null, err) | ||
| if (wallet.error) return retry('getBalance', null, wallet.error) |
| var client = publicClient() | ||
| client.api('ticker', params, function(err, quote) { | ||
| if (err) return retry('getQuote', func_args, err) | ||
| if (quote.error) return retry('getQuote', func_args, quote.error) |
| var client = authedClient() | ||
| client.api('cancel_order', params, function(err, body) { | ||
| if (err) return retry('cancelOrder', func_args, err) | ||
| if (body.error) return retry('cancelOrder', func_args, body.error) |
There was a problem hiding this comment.
(more weird indenting problems down below)
update-selectors.sh
Outdated
| node ./zenbot.sh backfill kraken.XETH-ZUSD --days 365 | ||
| node ./zenbot.sh backfill kraken.XXBT-ZCAD --days 365 | ||
| node ./zenbot.sh backfill kraken.XXBT-ZCAD --days 365 | ||
| node ./zenbot.sh backfill kraken.XETH-XXBT --days 365 |
There was a problem hiding this comment.
if you do not wish to include this file in your PR, you can just git rm update-selectors.sh and the usual git add --all git commit git push
docker-compose.yml
Outdated
| @@ -12,10 +12,12 @@ mongodb: | |||
| image: mongo:latest | |||
| volumes_from: | |||
| - mongodb-data | |||
| volumes: | |||
| - ./data/archive:/archive | |||
There was a problem hiding this comment.
I'm not sure what the point of this is, as far as I know mongo does nothing with /archive, so your ./data/archive is most likely empty?
There was a problem hiding this comment.
Yes, entirely. I use it to store a mongodump archive and to restore on the occasion I clear the volume (or want to restart from my snapshot). This isn't necessary, but I would recommend not exposing the db data files to the external host since Mongo uses memory mapped files and that isn't compatible in virtualized environments.
There was a problem hiding this comment.
I'll remove this since it isn't strictly related
Not related to this chance, didn't serve a particularly usefull purpose
DeviaVir
approved these changes
Jul 3, 2017
supersabbath
pushed a commit
to supersabbath/zenbot
that referenced
this pull request
Oct 2, 2017
* Docker compose update to use internal data volume. Makes it work with Docker for Windows * Initial exchange implemented Quadriga API public and private queries are working, testing the getQuote and getBalance. * JS Beautifier Config * Adjusting minimum and increments for quadriga products * Bug fixes and formatting * Fix bug in buy function (typo) prevent callback * Change formatting to follow the rest of zenbot * Fix markdown percentage option description * Fixed issues with buy command * Fix error handling in API calls * Prevent spamming calls to getOrder There is a general fall through to setTimer at the end of the function that must always run, the conditionals were causing additional uncessary checks which increases probability of hitting API rate limits. * Sell function tested and fixes * Fix formatting remove update-selectors script * Remove archives mapping from docker-compose.yml Not related to this chance, didn't serve a particularly usefull purpose * Update docker-compose.yml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the Quadruga API