This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Multiple Kraken API fixes/improvements #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
crubb
commented
Jul 8, 2017
crubb
commented
- Fix cancelOrders (Kraken - cancelOrder not working #303)
- Fix rejected trades on post only errors
- Improve detection of canceled trades
- Maybe fix sell orders executed multiple times (kraken sell command executed three times instead of once #339)
- Added more verbose debug logging
- Adjust timeouts for retry
DeviaVir
approved these changes
Jul 8, 2017
| @@ -176,7 +185,11 @@ module.exports = function container(get, set, clear) { | |||
| if (data.error.length) { | |||
| return cb(data.error.join(',')) | |||
| } | |||
| cb(null) | |||
| if (so.debug) { | |||
There was a problem hiding this comment.
That happened to be a tab. Fixed.
supersabbath
pushed a commit
to supersabbath/zenbot
that referenced
this pull request
Oct 2, 2017
* Kraken API: - Fix cancelOrders (DeviaVir#303) - Fix rejected trades on post only errors - Improve detection of canceled trades - Maybe fix sell orders executed multiple times (DeviaVir#339) - Added more verbose debug logging - Adjust timeouts for retry * Replaced a tab with spaces
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.