This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add amount for takers fee * Minor update to backfill warning text * Fix variable shadowing error * Trades with the same timestamp are now ordered oldest to newest when r eturned from getTrades * Trade volume now returned as number and not a string, prevents NaN on volume report * Filter results on timestamp start to prevent re-reporting the same trades in the results
Some argument about the lack of type safety in javascript.
* Clean up use of Number(), numbro() and String() in various API calls * Fix error with error reporting for getTrades * Clean up error handling conditions * Remove excess semicolons for consistency
This doesn't appear strictly necessary, but if it reduces API calls back to the platform it could result in fewer API over-limits.
DeviaVir
approved these changes
Jul 31, 2017
christian452
pushed a commit
to christian452/zenbot
that referenced
this pull request
Aug 4, 2017
…os8f-master * 'master' of https://github.com/carlos8f/zenbot: Improve command help for train command (DeviaVir#436) Support for missing win/loss and error rate from output (DeviaVir#426) Fix docker builds for forex.analytics (DeviaVir#424) Minor fixes for Quadriga trading API (DeviaVir#421) xmpp for trading alarms (DeviaVir#333) Strategies: TA (ema+macd) and Trust/Distrust (DeviaVir#285) Fixed docker build (DeviaVir#349) updated c.default_selector to c.selector in README.md (DeviaVir#418) added check for message before doing anything with it (DeviaVir#412) FIX: Properly check for unknown indicators in forex_analytics (DeviaVir#408) Added support for the BTCe exchange (DeviaVir#388) Add strategy: forex.analytics, an genetic optimization algorithm for TA-lib stats (DeviaVir#389) # Conflicts: # .gitignore # commands/sim.js # extensions/exchanges/bittrex/exchange.js # extensions/exchanges/quadriga/exchange.js # lib/engine.js # scripts/auto_backtester/backtester.js
supersabbath
pushed a commit
to supersabbath/zenbot
that referenced
this pull request
Oct 2, 2017
* Quadriga CX Fixes * Add amount for takers fee * Minor update to backfill warning text * Fix variable shadowing error * Trades with the same timestamp are now ordered oldest to newest when r eturned from getTrades * Trade volume now returned as number and not a string, prevents NaN on volume report * Filter results on timestamp start to prevent re-reporting the same trades in the results * Sometime opts.from is undefined, and we should return all results. * Formatting * Quadriga now supports trading LTC * Fixing QCX API handling of numbers Some argument about the lack of type safety in javascript. * QCX fix incorrect error reporting * * Adding debug output to help troubleshoot any more issues * Clean up use of Number(), numbro() and String() in various API calls * Fix error with error reporting for getTrades * Clean up error handling conditions * Remove excess semicolons for consistency * Fix error with retry in getBalance * QCX - Fix look up order * Re-enabled taker order processing in buy/sell command This doesn't appear strictly necessary, but if it reduces API calls back to the platform it could result in fewer API over-limits.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some final fixes. The API has been running in trading mode for several days now, so this should hopefully be the last of incoming fixes.