This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Update exchange products for BCH support #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Largely this is adding support for BCH Updated: bitfinex, bittrex, kraken Poloniex and gdax was updated, but had no changes. BTC-e could not be updated (broken update script) Quadriga doesn't support BCH BCH currency pairs on Kraken don't fully match what is returned by their API. ie: API says BCH-ZUSD, but only accepts BCH-USD. This is manually updated in the product list, I suspect it is a bug that will be rectified on their side in a few days. Tested all pairs via backfill.
supersabbath
pushed a commit
to supersabbath/zenbot
that referenced
this pull request
Oct 2, 2017
* Updating product lists for most exchanges Largely this is adding support for BCH Updated: bitfinex, bittrex, kraken Poloniex and gdax was updated, but had no changes. BTC-e could not be updated (broken update script) Quadriga doesn't support BCH BCH currency pairs on Kraken don't fully match what is returned by their API. ie: API says BCH-ZUSD, but only accepts BCH-USD. This is manually updated in the product list, I suspect it is a bug that will be rectified on their side in a few days. Tested all pairs via backfill. * Forgot to stage the BCH fix in Kraken.
This was referenced Jan 21, 2020
This was referenced Mar 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely this is adding support for BCH
Updated: bitfinex, bittrex, kraken
Poloniex and gdax was updated, but had no changes.
BTC-e could not be updated (broken update script)
Quadriga doesn't support BCH
BCH currency pairs on Kraken don't fully match what is returned by their API. ie: API says BCH-ZUSD, but only accepts BCH-USD. This is manually updated in the product list, I suspect it is a bug that will be rectified on their side in a few days and may require an additional future update.
Tested all pairs via backfill.