This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
The robo kitten patch #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 9, 2017 21:01
DeviaVir
approved these changes
Sep 11, 2017
|
Hey, I'm not sure this is correct. This setting seems to specify that no sell is undertaken if the loss on your order is >25% (at least per default config). It's used here: https://github.com/carlos8f/zenbot/blob/master/lib/engine.js#L458 Setting this to 0 sells even at a massive loss, instead of holding. It has nothing to do with "ensure selling at a higher price" and the comment is misleading. I would recommend reverting this commit. Best, |
supersabbath
pushed a commit
to supersabbath/zenbot
that referenced
this pull request
Oct 2, 2017
* Update conf-sample.js * Update conf-sample.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically self explanatory.
Just a small conf-sample.js note about max sell loss percent.