Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

WIP: docker-compose based command interface #663

Merged
merged 1 commit into from
Oct 30, 2017
Merged

WIP: docker-compose based command interface #663

merged 1 commit into from
Oct 30, 2017

Conversation

dkarlovi
Copy link
Contributor

Instead of using docker with linking and naming specific containers, we just execute the command through docker-compose itself.

@dkarlovi dkarlovi changed the title docker-compose based command interface WIP: docker-compose based command interface Oct 28, 2017
DeviaVir
DeviaVir approved these changes Oct 30, 2017
View reviewed changes
Copy link
Owner

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good: is it still WIP?

@dkarlovi
Copy link
Contributor Author

@DeviaVir yes, I'd like to figure out how we can deal with permissions mismatch in models and simulations when running via Docker (with or without Compose). We can merge this, I'll add an additional PR for that, though.

@DeviaVir DeviaVir merged commit ab5301b into DeviaVir:master Oct 30, 2017
@dkarlovi dkarlovi deleted the docker-tweaks branch October 30, 2017 08:27
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 6, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 25, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Sep 12, 2021
Open
@RafalSladek RafalSladek mentioned this pull request May 16, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkarlovi @DeviaVir