This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
stddev calculate on period #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
less api calls
DeviaVir
reviewed
Dec 11, 2017
| calculated = null | ||
| }, | ||
| onPeriod: function (s, cb) { | ||
| get('lib.ema')(s, 'stddev', s.options.stddev) |
There was a problem hiding this comment.
Odd indenting. Also, what calls the calculate() fn now?
There was a problem hiding this comment.
the caluculate method get's called with every single trade the bot receives. I don't think that we have to calculate the stddev on every trade but only when it's actually needed: In the onPeriod - call. It's not perfect but it's enough, imho.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
less api calls