New feature multiple selection was added. #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New feature to select multiple files with the option multiplePicker, async task was changed by coroutine worker, this is the new reccommended way by google to make async task. Some code refactor. Commented // mCropProvider.delete() because, it was removing image after generate, it was causing an error that image wasn't available when client wanted to consumed.
|
It's working correctly! Once the property is lost so that it returns several images, the callback is called as many times as images have been selected, and they are added to the files/DCIM folder |
|
Why is not merged ? It take too much time... |
|
This should be merged. Thanks |
|
I would love this feature to be merged! |
|
Be great to merge this! |
|
I would be really love to have this option. Could you tell me when we have it? |
|
@EkaterinaT89 Probably never since the last merged in this repository is 2021 |
|
Why was this not merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
New feature was added, multiple picker selection.
This feature is only availabe as picker and compression, not crop. The feature allows user to select multiple files from gallery and it's will be crompress, this feature is only for the new picker mode not legacy intent.
📄 Motivation and Context
The motivation is clear, give a feature neccesary multiple files selector.
🧪 How Has This Been Tested?
Tested with the example, but I haven't the neccesary know how to test properly.
📦 Types of changes
✅ Checklist