[feat] Add the command usage syntax hint #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhdevelop
force-pushed
the
hint-command-usage
branch
from
57166dc
to
fae2b1c
Compare
shubhdevelop
force-pushed
the
hint-command-usage
branch
from
bcd3fd4
to
897187c
Compare
lucifercr07
reviewed
Oct 8, 2024
src/data/commandSyntaxMap.ts
Outdated
| parts: SyntaxPart[]; | ||
| }; | ||
|
|
||
| export type SyntaxMap = { |
There was a problem hiding this comment.
Can't we utilise existing? It won't be feasible to maintain two separate maps in same repo.
export interface DiceCmdMeta {
title: string;
syntax: string;
body: string;
url?: string;
}
There was a problem hiding this comment.
I was thinking of migrating from this CmdMeta to later format only. But in a separate issue, it gives us more control.
I don't want to maintain two metaData as well, I'm leaving the previous cmdMeta for now, because I don't want anything to break while we transition to the other format.
we can extend my format in a way that it will be compatible with search functionality as well
There was a problem hiding this comment.
@lucifercr07 do we agree on this?
shubhdevelop
force-pushed
the
hint-command-usage
branch
from
897187c
to
c144283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #36
This PR adds a new feature that shows command usage hint as the user type in the command
SET GET DELDevelopment Tested
Screencast.from.2024-10-06.02-45-22.mp4