Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command Migration: ('JSON.RESP', 'JSON.DEBUG', 'JSON.INGEST') #1161

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Command Migration: ('JSON.RESP', 'JSON.DEBUG', 'JSON.INGEST') #1161

wants to merge 1 commit into from

Conversation

HarshKhatore
Copy link

This PR migrates JSON.RESP, JSON.DEBUG and JSON.INGEST to make it protocol agnostic. Closes #1030

Migration Checklist

  • Migrated the evalXXX function with the latest definition
  • Update or add unit tests for the new implementation.
  • All unit tests pass successfully.
  • Ensure all integration tests pass successfully.
  • Ensure integration tests are added for the migrated command on multi-threaded resp server.
  • Add http, websocket tests for the commands
  • Move Integration tests for the respective commands under the RESP integration tests directory from Async directory
  • Please validate that the documentation for the respective commands is up to date. If not then consider adding them.

@AshwinKul28 AshwinKul28 added the migration -- command Migrates current eval to a refactored eval for all protocols functionality label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumya-codes soumya-codes Awaiting requested review from soumya-codes

Assignees
No one assigned
Labels
migration -- command Migrates current eval to a refactored eval for all protocols functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command Migration: ('JSON.RESP', 'JSON.DEBUG', 'JSON.INGEST')
2 participants
@HarshKhatore @AshwinKul28