Issue-1103 - Fixing broken pipe errors #1170
Open
+24
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this contribution, please fix the lint errors and merge conflicts |
|
Hey @JyotinderSingh! Sure, i would resolve the merge conflicts, however I believe the linting errors existed even before I tried to make any change as they are in files different to the one I had made changes to, I don't want to break the codebase |
- imports changed
- outdented the code from the else block due to break statement in
if block
- removed extra blank line for consistent formatting
|
Hey @JyotinderSingh! I think the code should be good for review now , thank you for the help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The identification of broken pipe is only when there is an abrupt exit, so what I saw in the codebase was there are only a couple of places that deal with the closure of WebSocket connections, most of them were only handling the case where the user exited irrespective if it was gracefully or abruptly, so I modified and added some sections for the same
closing_handshake, it wasn't checking if the closeValue had an error, indicating that there was an error while closing the connection, so I added a check for the sameerrscategory, it means that there is a graceful exit, otherwise, the exit was due to another error, so I have added the check for the sameWriteResponseWithRetriesyou have a case where the function returns thesyscall.EPIPEerror, this function is utilized in WebSocketHandler function, so I have added the check for the sameThose were all the that i found were capable of returning broken pipe errors, i have provided the segregated messages for the same, please do let me know if any other changes or features are needed
Fixes #1103
Thank you!