Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#30: Add integration tests for commands execution related to hyperloglog #38

Merged
merged 7 commits into from
Oct 20, 2024

Conversation

tarun-kavipurapu
Copy link
Contributor

Integration tests Issue #30

@lucifercr07 also in the documentation for this the return values are wrong i made the tests according to the results given by cli

@tarun-kavipurapu
Copy link
Contributor Author

tarun-kavipurapu commented Oct 14, 2024

@lucifercr07 the actual values in integration tests are different locally and in the github workflows what should i do?

@lucifercr07 lucifercr07 changed the title Fix/issue 30 #30: Add integration tests for commands execution related to hyperloglog Oct 17, 2024
@lucifercr07
Copy link
Contributor

@tarun-kavipurapu please fix the failing tests.

@lucifercr07
Copy link
Contributor

@tarun-kavipurapu please fix the failing tests, let me know if any help is required.

@lucifercr07 lucifercr07 merged commit 0d419f6 into DiceDB:master Oct 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants