Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shinobu getting confused when ID is in file name. #385

Closed
Nixis198 opened this issue Jan 4, 2021 · 3 comments
Closed

Shinobu getting confused when ID is in file name. #385

Nixis198 opened this issue Jan 4, 2021 · 3 comments

Comments

@Nixis198
Copy link
Contributor

Nixis198 commented Jan 4, 2021

LRR Version and OS
LRR Version: 0.7.5 - "Underground"
OS: UNRAID
Install Method: Docker

Bug Details
If the ID of the manga is the first thing in the file title Shinobu will use that as the manga name. IE. if i download let's say https://nhentai.net/g/342540/ it will be saved in a zip folder called "342540. [cabin] Love Divided Between a Rock and a Hard Place Ch.1[English] [K&S]". If I then take that zip folder and put it in LRR's content folder it will show up as "342540." If I then try to use the nhentai plugin to get tags for it it will either not find a nhentai page for it or will not be the right tags.

If I manually remove the "342540. " from the name of the zip file everything works perfectly. But I am unable to do this for my all my files.

Matching Logs
Shinobu logs when I add a manga with the ID in the name:
[2021-01-04 01:42:00] [Shinobu] [info] Adding new file /home/koyomi/lanraragi/content/342540. [cabin] Love Divided Between a Rock and a Hard Place Ch.1[English] [K&S].zip with ID 2e5a6caaa10669e000d97be8159ed1b77a85d3e7

Screenshots
Here is a screenshot of what it looks like.
Screenshot 2021-01-03 204306

@Nixis198
Copy link
Contributor Author

Nixis198 commented Jan 4, 2021

I ended up making a plugin that reads the url from the info.txt file then pulls the tags and title from nhentai.net. It was my first time writing in perl and I know it can be better but from my testing it works. If you want to include it as plugin that comes with it just ask me to open a pull request.

@Difegue
Copy link
Owner

Difegue commented Jan 4, 2021

Great work! 👍 It is a bit rough around the edges, but if it got you setup that's all that matters.

As you've probably seen, the current nHentai plugin is a bit dumb as it only does a text search with the name of the zip.
If the (id). [(artist)] (name).zip syntax is the default for stuff downloaded from nH, it'd be interesting to update the stock plugin to first try getting the ID from the filename(using what you wrote here basically), then fallback to the existing search mechanism.

I won't accept a PR for an extra plugin since it's a bit too similar to stock, but if you feel up for doing what I wrote above, I'd certainly merge that. 👀

Difegue added a commit that referenced this issue Feb 13, 2021
@Difegue
Copy link
Owner

Difegue commented Feb 13, 2021

I've moved auto-parsing to a plugin and made it so it won't be enabled by default for new users.
I still think the stock NH plugin could be improved to try detecting GIDs in the filename and using them instead of doing a text search, but as far as this issue's concerned we're essentially done. 😤

@Difegue Difegue closed this as completed Feb 13, 2021
Difegue added a commit that referenced this issue Mar 11, 2021
* [ImgBot] Optimize images

*Total -- 955.60kb -> 756.84kb (20.8%)

/tools/Documentation/.gitbook/assets/ratings.png -- 131.97kb -> 86.23kb (34.66%)
/tools/Documentation/.gitbook/assets/index.png -- 193.08kb -> 129.82kb (32.76%)
/tools/Documentation/.gitbook/assets/archive_thumb.jpg -- 630.55kb -> 540.78kb (14.24%)

Signed-off-by: ImgBotApp <[email protected]>

* Do not show page select when there are no results

* Also hide table header

* Update buildx action to the official Docker one

* Update s6

* Update less, the alpine package doesn't seem to have s6-overlay-preinit yet?

* pin s6 alpine package

* Rollback alpine base for now

* Fix ARM builds (#394)

* Update push-continous-delivery.yml

* Update release-delivery.yml

* Update push-continous-delivery.yml

* Update push-continous-delivery.yml

* Improve visibility when sorting table columns + fix being able to put whitespace as a custom column

* Fix context menu applying to overlays

* (#374) Remove cooldown on auto-plugin as it's basically useless

* Fix memory leak caused by the Parallel::Loops/Storable combo in the Search API

* Add some basic retrying logic on our first Redis connection
This avoids dying unnecessarily if Redis takes a while to load into memory.

* Accept "false" properly for pinned on category creation

* Also fix the update_cat endpoint

* Remove favtagmigration script

* Add a simple GET to /api/categories/:id

* (#335) Reading progression is now server-side!

* Fix method for progress in docs

* Fix docs thanks for nothing gitbook

* (#385) (#397) Remove the built-in Auto-Tag feature in favor of a Filename parsing plugin

* Fix tests

* Avoid uninitialized warnings if there's no progress/pagecount in DB

* Add a pageread stat and actually use the package.json description 'cause why not

* Remove unnecessary datatables cdn include

* (#282) Rewrite Shinobu filemap so it relies on Redis and keeps state between restarts

* (#405) Add job + api req to regen all thumbnails
Also remove redis loading timeout for REALLY BIG dataset

* (#410) NFC all the things

* Add fa-solid-900.woff2 to the vendor deps
so that browsers finally shut up about it, also added fa-regular

* Fix submenu arrow colors in the various themes

* autism

* Add an API endpoint to return which categories an ID belongs to

* (#375) Rework context menu so it uses the new endpoint to remove archives from categories

* More doc details on the reading progression API

* Some more documentation fixes

* MORE Documentation updates gee

* (#412) Add autofocus to the password input in login

* (#397) Add a check to RegexParse to avoid putting numbers as languages

* (#414) Fix regexparse not decoding the filesystem path + decode log in minion upload for extra clarity

* (#389) Update magick to v7 in homebrew

* backport changes from homebrew-core
those guys write ruby way better than I do

* Fix brew test runs

* (#389) Add libheif to Dockerfile and unlock avif/heif support

* Don't recommend homebrew for linux since it doesn't work out of the box atm

* Add Mojolicious::Plugin::Status when running in debug mode

* Update docs to fix wrong json examples

* Stop using a static secret for mojo's cookie signatures

* Remove the auto-plugin toggle and matching pref
It's a bit unnecessary considering plugins have to be toggled manually anyways.

* Rework Plugin Configuration page a bit further

* (#267) Make the thumbnail folder location an option

* [ImgBot] Optimize images (#416)

/tools/Documentation/.gitbook/assets/thumbchange.png -- 55.64kb -> 36.35kb (34.67%)

Signed-off-by: ImgBotApp <[email protected]>

Co-authored-by: ImgBotApp <[email protected]>

* Add some JS to migrate local reading progression

Co-authored-by: ImgBotApp <[email protected]>
Co-authored-by: Cirno the Strongest <[email protected]>
Co-authored-by: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants