Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koromo metadata plugin sees only case-sensitive "Info.json" #587

Closed
Solipso opened this issue Feb 8, 2022 · 2 comments
Closed

Koromo metadata plugin sees only case-sensitive "Info.json" #587

Solipso opened this issue Feb 8, 2022 · 2 comments

Comments

@Solipso
Copy link

Solipso commented Feb 8, 2022

LRR Version and OS

OS: Docker, LRR version: 0.8.4, Koromo plugin version: 2.0

Bug Details

Archive with "info.json" is not seen by Koromo metadata plugin (error: No koromo info.json file found in this archive!)

Archive with "Info.json" is perfectly recognized.

@ndbiaw
Copy link
Contributor

ndbiaw commented Feb 8, 2022

This has been known and reported. At line 43 in ./lib/LANraragi/Plugin/Metadata/Koromo.pm:
Change

my $path_in_archive = is_file_in_archive( $file, "Info.json" );

to

my $path_in_archive = is_file_in_archive( $file, "info.json" );

And it's not an bug either. Koromo's info file is exactly "Info.json", although there are several other file types of rip tools that have a similar format and can be used with the Koromo tool, but it not Koromo's info file.

@Difegue
Copy link
Owner

Difegue commented Feb 9, 2022

While it's not a bug, the koromo plugin is increasingly becoming this weird catch-all thing since its format is kinda generic, so I don't mind adding a check for the lowercase version as well if it can unblock some people. 👍

@Difegue Difegue closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants