EH language tag needs to be deleted twice to get removed from metadata.

[soarpasser]

LRR Version and OS
0.8.5 Windows msi

Bug Details
As stated in title -
When you use the "E-Hentai" plugin to apply tags to a certain gallery, the language tag needs to be deleted twice to disappear from the metadata.

Reproducing this issue:

1. pick any gallery
   
2. enter a EH gallery link, tags gets applied.
   
3. clicks the × next to the language tag I wish to remove, and click on "save metadata".
   
4. refreshes the page - the tag that I wanted to remove is still there.
   
5. repeat step 3 and refresh again, now the tag actually gets removed.
   

Not sure if this is a plugin-related issue or an issue with the application. Figured I'd report it here anyways.

Matching Logs
Nothing of note.

[Difegue]

👋 I'm not sure this is an issue with the actual metadata storage, it might just be browser cache showing you the old tag even though it's been removed. (There's some specific code to prevent this but it might still happen on specific browsers?)

Can you try refreshing between each step with Ctrl+F5 instead of just F5 and see if that changes anything? Thanks!

[soarpasser]

In fact I do use Ctrl+F5 when refreshing - I have it bound to a button on my mouse. So it definitely isn't a browser cache issue.

More evidence that supports this point is that when I remove other tags together with the language tag in Step 3 (e.g. source link, various other tags, etc...) and refresh, those get removed properly but the language tag always stays no matter how many times you refresh unless you delete it again. In fact it even stays after a restart of the LR client/system.

In case it helps, browser used here is Firefox 64bit version 102.0

[Difegue]

Good to know, that probably does mean that there's an issue with the metadata system. I'll try to look it up.

[Difegue]

Narrowing things down, this isn't a specific bug with the metadata system, plugin or language tags, but with the edit form: It seems that deleting the first tag added by a plugin in the list after applying a plugin never works.

Refreshing the edit form, then deleting the tag works. This is because plugin runs have a leading space, which is then misinterpreted by tagger.js when we delete the tag. 🫠
This will be fixed in the next release, thanks for the report!