Progress tracking can fail for infinite scroll #865
Labels
Comments
|
🤔 Couldn't we just lower the observer threshold? |
|
Fiddling with the threshold should work, or at least make it less likely to fuck up. Omakase! |
Difegue
added
good first issue
hacktoberfest
misc. frontend
reader
and removed
misc. frontend
labels
Difegue
added a commit
that referenced
this issue
Dec 16, 2023
Progress tracking doesn't trigger in infinite scroll when pages are too tall AND when you are using the mousewheel or similar. This happens because the IntersectionObserver threshold is set to 0.8, and is thus never triggered if 80% of a page is never visible at one time.
|
I've lowered the threshold to 50%. I guess the issue can still happen with very long webtoon-ass images, but at this point I'm just putting the blame on you for not chopping up your images a teensy bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
LRR Version and OS
Latest nightly, Linux, Docker.
Bug Details
Progress tracking doesn't trigger in infinite scroll when pages are too tall AND when you are using the mousewheel or similar. This happens because the IntersectionObserver threshold is set to 0.8, and is thus never triggered if 80% of a page is never visible at one time.
Basically, this shit: w3c/IntersectionObserver#124
The text was updated successfully, but these errors were encountered: