Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#943) Save japanese title from Chaika.moe metadata #967

Merged
merged 2 commits into from
May 7, 2024
Merged

(#943) Save japanese title from Chaika.moe metadata #967

merged 2 commits into from
May 7, 2024

Conversation

BWsix
Copy link
Contributor

@BWsix BWsix commented Apr 17, 2024

This PR adds option Save the original title when available instead of the English or romanised title in Chaika metadata plugin, as proposed in #943:

Screenshots

Settings page:
Screenshot from 2024-04-17 16-35-11

Before enabling the option:
Screenshot from 2024-04-17 16-48-19

After enabling the option, I think it's working as intended (the first one has jp title and the second one does not):
Screenshot from 2024-04-17 16-40-32

Notes

This is my first time coding in perl, but I literally copied how EHentai plugin did https://github.com/Difegue/LANraragi/blob/dev/lib/LANraragi/Plugin/Metadata/EHentai.pm so it should be fine..?

Before commit, I ran npm run critic and the file I touched passed the lint:
image

@Difegue Difegue linked an issue Apr 17, 2024 that may be closed by this pull request
@Difegue
Copy link
Owner

Difegue commented May 7, 2024

Looks good to me. Sorry for the delay, this PR completely slipped by my notifications..

@Difegue Difegue merged commit 7397258 into Difegue:dev May 7, 2024
1 check passed
Copy link

holopin-bot bot commented May 7, 2024

Congratulations @BWsix, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clvvoetan08290flfbkm22tjy

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] save japanese title from Chaika.moe metadata
2 participants