(#943) Save japanese title from Chaika.moe metadata #967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds option
Save the original title when available instead of the English or romanised title
in Chaika metadata plugin, as proposed in #943:Screenshots
Settings page:
Before enabling the option:
After enabling the option, I think it's working as intended (the first one has jp title and the second one does not):
Notes
This is my first time coding in perl, but I literally copied how EHentai plugin did https://github.com/Difegue/LANraragi/blob/dev/lib/LANraragi/Plugin/Metadata/EHentai.pm so it should be fine..?
Before commit, I ran
npm run critic
and the file I touched passed the lint: