Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web app manifest #977

Merged
merged 1 commit into from
May 30, 2024
Merged

Add web app manifest #977

merged 1 commit into from
May 30, 2024

Conversation

jacobgkau
Copy link
Contributor

@jacobgkau jacobgkau commented May 29, 2024

This allows installing the website as a progressive web app (PWA) on mobile devices and certain web browsers. That's useful to be able to use the app without having the URL bar/tab bar getting in the way.

Relevant docs:

I've tested this on two Android devices (Android 9 and 14).

@Difegue
Copy link
Owner

Difegue commented May 29, 2024

Looks good to me. Does it work fine when you start browsing through the web front? (ie edit, reader, etc)
Since we're not a single-page app, I always thought browsers would just start popping additional windows for everything if we declared ourselves as a PWA.

@jacobgkau
Copy link
Contributor Author

I did test the reader and the admin login before opening the PR to make sure they didn't pop additional windows. On my Android devices, everything stays within the same window.

PWA manifests definitely aren't limited to single-page apps, as Google's docs state:

Caution: If your PWA includes multiple HTML pages, make sure to link its manifest to all of them.

To be on the safe side, I'll go ahead and add the manifest link to the rest of the HTML templates. I'm also changing the spaces to a tab to match the other content in that part of the templates.

This allows installing the website as a progressive web app (PWA) on mobile devices and certain web browsers.
@Difegue Difegue merged commit f446203 into Difegue:dev May 30, 2024
Copy link

holopin-bot bot commented May 30, 2024

Congratulations @jacobgkau, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clwt14oq325130cjpq1udqb2n

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@jacobgkau jacobgkau deleted the pwa-manifest branch May 30, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants